tests: napi_get_last_error_info #19190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
reviewed
Apr 21, 2024
Comment on lines
+1892
to
+1912
| "Invalid argument", | ||
| "An object was expected", | ||
| "A string was expected", | ||
| "A string or symbol was expected", | ||
| "A function was expected", | ||
| "A number was expected", | ||
| "A boolean was expected", | ||
| "An array was expected", | ||
| "Unknown failure", | ||
| "An exception is pending", | ||
| "The async work item was cancelled", | ||
| "napi_escape_handle already called on scope", | ||
| "Invalid handle scope usage", | ||
| "Invalid callback scope usage", | ||
| "Thread-safe function queue is full", | ||
| "Thread-safe function handle is closing", | ||
| "A bigint was expected", | ||
| "A date was expected", | ||
| "An arraybuffer was expected", | ||
| "A detachable arraybuffer was expected", | ||
| "Main thread would deadlock", |
There was a problem hiding this comment.
should these be cstrings? (NUL terminated)
Comment on lines
-1897
to
+1942
| error_message: std::ptr::null(), | ||
| engine_reserved: std::ptr::null_mut(), | ||
| engine_error_code: 0, | ||
| error_code: napi_ok, | ||
| error_message: env.last_error.error_message, | ||
| engine_reserved: env.last_error.engine_reserved, | ||
| engine_error_code: env.last_error.engine_error_code, | ||
| error_code: env.last_error.error_code, | ||
| }); | ||
|
|
||
| *error_code = Box::into_raw(err_info); | ||
| *result = Box::into_raw(err_info); |
There was a problem hiding this comment.
Not a change in this PR but I think this leaks memory. There should be a static napi_extended_error_info that can be reused.
|
Already done in #24101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.