Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/napi): handle finalizers #19168

Merged
merged 9 commits into from
May 18, 2023
Merged

fix(cli/napi): handle finalizers #19168

merged 9 commits into from
May 18, 2023

Conversation

littledivy
Copy link
Member

Fixes #17325

@littledivy littledivy marked this pull request as ready for review May 17, 2023 16:48
bartlomieju
bartlomieju reviewed May 17, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but there are multiple places in other APIs that accept finalize_cb and finalize_hint that seem to be unused (eg. napi_create_external_buffer). Could you handle those in this PR as well?

tools/node_compat/node Outdated Show resolved Hide resolved
@littledivy littledivy changed the title fix(cli/napi): add napi_add_finializer fix(cli/napi): handle finalizers May 18, 2023
bartlomieju
bartlomieju approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work

@littledivy littledivy merged commit c3f7e6e into denoland:main May 18, 2023
10 checks passed
@bartlomieju bartlomieju deleted the napi_add_finializer branch May 18, 2023 13:46
levex pushed a commit that referenced this pull request May 18, 2023
@littledivy @levex
fix(cli/napi): handle finalizers (#19168)
81f3ce9 
Fixes #17325
@bartlomieju bartlomieju mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node-API: napi_add_finalizer is not implemented
2 participants
@littledivy @bartlomieju