feat: Adaptations to support OpenBSD port #19153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aapoalas
approved these changes
May 16, 2023
VlkrS
changed the title
lino-levan
approved these changes
May 18, 2023
If that is on option on the table, I can try to whip some of the more intrusive changes needed for the port into shape as well. |
mmastrac
reviewed
May 31, 2023
Nit fixed :-) |
Any chance that this might make it into 1.35? |
bartlomieju
pushed a commit
that referenced
this pull request
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I understand that OpenBSD is not a supported platform, but since it would make maintaining the OpenBSD port a lot easier, I assembled a few patches that I believe should not get in your way for your consideration.
In those cases where I found the FreeBSD port to contain the same adaptations, I included FreeBSD as well.
Edit: This is part of the resolution to #8012. I would not consider the remaining patches we need to be fit for inclusion in deno mainline.