Update to TypeScript 3.3 #1908
Merged
Update to TypeScript 3.3 #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Aside: I like the TypeScript release number) |
|
@kevinkassimo yeah, it caused a bit of a controversy though... as of course the next version would have to be |
ry
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Deno to TypeScript 3.3. There was a change in behaviour between 3.2 and 3.3 that was causing some issues in the upgrading. Previously
noLibwould allow you to specify the libraries you wanted to include in thefilesand have the references to other libraries to be resolved. That stopped working in 3.3, which the previous behaviour was unintended. Now we have to supply the base library (esnext) in theliboption. The reason we do this is that it ensure thatdomandscripthostare not loaded which would potentially allow some features that Deno does not support get past the build process of Deno.