Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: use jemalloc as global allocator #18957

Merged
merged 3 commits into from
May 2, 2023

Conversation

bartlomieju
Copy link
Member

Follow up to #18875 that enables jemalloc
as a global allocator for the Deno CLI.

@bartlomieju bartlomieju requested review from ry and littledivy May 2, 2023 14:54
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bartlomieju bartlomieju merged commit 798c1ad into denoland:main May 2, 2023
@bartlomieju bartlomieju deleted the jemalloc_for_cli branch May 2, 2023 22:36
levex pushed a commit that referenced this pull request May 4, 2023
Follow up to #18875 that enables
`jemalloc` as a global allocator for the Deno CLI.
bartlomieju added a commit to bartlomieju/deno that referenced this pull request May 18, 2023
bartlomieju added a commit that referenced this pull request May 19, 2023
This reverts commit 798c1ad.

Reverting because this change caused a spike in memory usage, but we
can't fully realise gains from lower GC pressure from more optimal
malloc/ free provided by "jemalloc". 

We might revisit the topic in future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants