Cleanup node_modules, update packages #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm the lint failures are not related to this PR, there came in another commit, but it seems for whatever reason, linting wasn't effectively running for a while until this PR got it working again. I will make the changes. |
ry
approved these changes
Mar 7, 2019
|
Interesting side effect, we used to lose the |
|
@kitsonk Ok - the increase is negligible - thanks. 77mb -> 81mb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
package.jsonto do a bit of cleanup as well as "pin" all the versions that are installed so there is a lower risk of them "floating" to unintended versions.Also, this PR introduced a
.yarncleanwhich removes non-essential files when yarn is run to install or update packages. This will help keepAlso, this moves from
ts-simple-astto the renamed projectts-morph.There were a few regressions in the library builder (independent of
ts-simple-astthat occurred when doing a clean install of thenode_moduleswhich needed to be addressed, but also improved the logging of the tool which helped in isolating the issues.