Revert "refactor: don't expose Deno[Deno.internal].core namespace" #18881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Apr 27, 2023
| // NOTE(bartlomieju): writing a 0.5Gb file might be too much for CI, | ||
| // so skip running if writing fails. | ||
| return; | ||
| } |
There was a problem hiding this comment.
Maybe this should be a separate PR in case we revert the revert? (Not a big deal)
There was a problem hiding this comment.
I'd rather get it in here, instead of waiting for another PR to pass CI
| Deno.writeFileSync(filePath, bytes); | ||
| try { | ||
| Deno.writeFileSync(filePath, bytes); | ||
| } catch (e) { |
There was a problem hiding this comment.
Do we have a way to check the specific error instead of returning on all errors?
There was a problem hiding this comment.
It's OS specific so I'm not sure what will the error be on other OSes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also conditionally disabled one test if there's not enough space on device.