Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gn build needs use-snapshots-init enabled. #1886

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Gn build needs use-snapshots-init enabled. #1886

merged 3 commits into from
Mar 5, 2019

Conversation

afinch7
Copy link
Contributor

@afinch7 afinch7 commented Mar 5, 2019

No description provided.

@afinch7
Copy link
Contributor Author

afinch7 commented Mar 5, 2019 •
edited
Loading

This should fix the startup times. I didn't occur to me that build.py doesn't even care about build.rs. I added the feature for snapshots init to the BUILD.gn.

@afinch7 afinch7 mentioned this pull request Mar 5, 2019
Closed
@afinch7
Copy link
Contributor Author

afinch7 commented Mar 5, 2019

Rebased this one it should be good to go as soon as you complete review.

ry
ry reviewed Mar 5, 2019
View reviewed changes
BUILD.gn Outdated Show resolved Hide resolved
@afinch7
Copy link
Contributor Author

afinch7 commented Mar 5, 2019

Requested changes are in, and I did a cleanup of isolate_inti.rs.

ry
ry approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@ry ry merged commit da004fb into denoland:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afinch7 @ry