Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): improve vm.runInThisContext #18767

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix(ext/node): improve vm.runInThisContext #18767

merged 2 commits into from
Apr 19, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 19, 2023

This PR improves the compatibility of vm.runInThisContext

closes #17853

@kt3k kt3k requested a review from bartlomieju April 19, 2023 07:51
bartlomieju
bartlomieju approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@kt3k kt3k merged commit 53c9f59 into denoland:main Apr 19, 2023
@kt3k kt3k deleted the fix-node-vm-runInThisContext branch April 19, 2023 14:26
@bartlomieju bartlomieju mentioned this pull request Apr 23, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect behavior of node:vm.runInThisContext()
2 participants
@kt3k @bartlomieju