Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kv): AtomicOperation#sum #18704

Merged
merged 3 commits into from
Apr 15, 2023
Merged

feat(kv): AtomicOperation#sum #18704

merged 3 commits into from
Apr 15, 2023

Conversation

ry
Copy link
Member

@ry ry commented Apr 14, 2023

No description provided.

@ry ry requested review from lucacasonato and losfair April 14, 2023 11:27
lucacasonato
lucacasonato reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add -> sum?

Otherwise it doesn't match the mutation type

@losfair losfair changed the title feat(kv): AtomicOperation#add feat(kv): AtomicOperation#sum Apr 14, 2023
losfair
losfair approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure about making sum take a bigint instead of KvU64 (wanted to keep the semantics clear), but since it's the only type accepted it seems fine...

@ry ry merged commit 2184103 into main Apr 15, 2023
@ry ry deleted the kv_add branch April 15, 2023 08:33
levex pushed a commit that referenced this pull request Apr 18, 2023
@ry @levex
feat(kv): AtomicOperation#sum (#18704)
4e0bfaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@losfair losfair losfair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ry @losfair @lucacasonato