Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): add process sigint handler for --watch #18678

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(test): add process sigint handler for --watch #18678

merged 1 commit into from
Apr 12, 2023

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #18676.

bartlomieju
bartlomieju approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it fixes the issue. LGTM, thanks for quick turnaround Nayeem.

@bartlomieju bartlomieju merged commit d97f9d2 into denoland:main Apr 12, 2023
@nayeemrmn nayeemrmn deleted the sigint-test-watch branch April 16, 2023 04:21
levex pushed a commit that referenced this pull request Apr 18, 2023
@nayeemrmn @levex
fix(test): add process sigint handler for --watch (#18678)
a1845a0 
Fixes #18676.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno test --watch cannot be interrupted with sigint while waiting for restart
2 participants
@nayeemrmn @bartlomieju