Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(check): ensure diagnostics caused by changes in other files get invalidated between runs #18541

Merged
merged 2 commits into from
Apr 1, 2023
Merged

fix(check): ensure diagnostics caused by changes in other files get invalidated between runs #18541

merged 2 commits into from
Apr 1, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Apr 1, 2023 •
edited
Loading

Regression caused by the performance improvement in #18329. Figuring this out was hard. It's luckily still fast after this change.

Closes #18516

dsherret
dsherret commented Apr 1, 2023
View reviewed changes
test_util/src/builders.rs
}

pub fn use_http_server(&mut self) -> &mut Self {
pub fn use_http_server(mut self) -> Self {
Copy link
Member Author

@dsherret dsherret Apr 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better in the actual test files. The other way was slightly annoying.

@dsherret dsherret mentioned this pull request Apr 1, 2023
Closed
bartlomieju
bartlomieju approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix, I'm sure it was painful to debug it

@dsherret dsherret merged commit 23b9be7 into denoland:main Apr 1, 2023
@dsherret dsherret deleted the fix_check_diagnostics_other_file branch April 1, 2023 14:05
dsherret added a commit that referenced this pull request Apr 1, 2023
@dsherret
fix(check): ensure diagnostics caused by changes in other files get i…
94d8ac5 
…nvalidated between runs (#18541)

Regression caused by the performance improvement in #18329. Figuring
this out was hard. It's luckily still fast after this change.

Closes #18516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno check cache causes wrong results
2 participants
@dsherret @bartlomieju