Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/ffi): crash when same reference struct is used in two fields #18531

Merged
merged 1 commit into from
Apr 1, 2023
Merged

fix(ext/ffi): crash when same reference struct is used in two fields #18531

merged 1 commit into from
Apr 1, 2023

Conversation

DjDeveloperr
Copy link
Contributor

fix #17482

aapoalas
aapoalas approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Christ

littledivy
littledivy approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit c162647 into denoland:main Apr 1, 2023
@DjDeveloperr DjDeveloperr deleted the fix-ffi-nested-struct branch April 1, 2023 05:32
dsherret pushed a commit that referenced this pull request Apr 1, 2023
@DjDeveloperr @dsherret
fix(ext/ffi): crash when same reference struct is used in two fields (#…
fcc414b 
…18531)

fix #17482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when FFi involves variables for nested structures
3 participants
@DjDeveloperr @aapoalas @littledivy