feat(ext/ffi): support marking symbols as optional #18529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aapoalas
approved these changes
Mar 31, 2023
bartlomieju
reviewed
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for marking Foreign Library symbols as
optional, which does not prevent the library from loading in case an optional symbol is not found.For example, when loading Vulkan library, certain symbols related to extensions are not present on all machines, so we mark them as optional and allow the library to still load. It's also helpful in case certain symbols are OS-specific. Some system libraries like win32 (user32, etc) may have symbols that are only present on newer version of Windows, so it can also allow compatibility with older versions.