Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/kv): return versionstamp from set/commit #18512

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Mar 30, 2023

This commit updates the Deno.Kv API to return the new commited
versionstamp for the mutated data from db.set and ao.commit. This is
returned in the form of a Deno.KvCommitResult object that has a
versionstamp property.

This commit updates the `Deno.Kv` API to return the new commited
versionstamp for the mutated data from `db.set` and ao.commit`. This is
returned in the form of a `Deno.KvCommitResult` object that has a
`versionstamp` property.
Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato merged commit e888c3f into main Mar 30, 2023
@lucacasonato lucacasonato deleted the kv_committed_versionstamp branch March 30, 2023 18:57
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
This commit updates the `Deno.Kv` API to return the new commited
versionstamp for the mutated data from `db.set` and `ao.commit`. This is
returned in the form of a `Deno.KvCommitResult` object that has a
`versionstamp` property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants