Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify Deno.consoleSize returns the window size #18508

Merged
merged 1 commit into from
Mar 30, 2023
Merged

docs: clarify Deno.consoleSize returns the window size #18508

merged 1 commit into from
Mar 30, 2023

Conversation

dsherret
Copy link
Member

Closes #18477

@dsherret dsherret mentioned this pull request Mar 30, 2023
Closed
bartlomieju
bartlomieju approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 3abc53f into denoland:main Mar 30, 2023
@dsherret dsherret deleted the docs_add_info_console_size branch March 30, 2023 15:47
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@dsherret @mmastrac
docs: clarify Deno.consoleSize returns the window size (#18508)
04de349 
Closes #18477
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno.consoleSize + full-width text/ansi escape codes is bug-prone with no official way of mitigating
2 participants
@dsherret @bartlomieju