fix(repl): improve package.json support #18497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick fix! Does this mean that REPL will still look for package.json even before there's an import? Why does it need to do that? |
Yes, it will still do that. It's because the repl internally uses the lsp and the lsp eagerly loads it. The lsp eagerly loads it in order to have consistent/deterministic npm resolution regardless of what files are currently open or loaded. |
|
Thinking about it more, we could maybe only use the lockfile as a source of truth for deterministic resolution. I will look into changing this. Edit: This is now resolved. |
dsherret
changed the title
dsherret
commented
Mar 29, 2023
| @@ -106,7 +106,7 @@ pub fn result_to_evaluation_output( | |||
| match r { | |||
| Ok(value) => value, | |||
| Err(err) => { | |||
| EvaluationOutput::Error(format!("{} {}", colors::red("error:"), err)) | |||
| EvaluationOutput::Error(format!("{} {:#}", colors::red("error:"), err)) | |||
There was a problem hiding this comment.
Outputs the error with context.
bartlomieju
approved these changes
Mar 30, 2023
| super::logging::set_lsp_log_level(log::Level::Debug); | ||
| super::logging::set_lsp_warn_level(log::Level::Debug); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17929
Closes #18494