feat(ext/node): add crypto.checkPrime API
#18465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
bartlomieju
reviewed
Mar 28, 2023
bartlomieju
approved these changes
Mar 28, 2023
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
Towards #18455 This commit implements `checkPrimeSync` and `checkPrime` in node:crypto using the Miller-Rabin primality test (fun fact: it actually is a test for composite numbers) It first compares the candidate against many known small primes and if not, proceeds to run the Miller-Rabin primality test. http:https://nickle.org/examples/miller-rabin.5c used as reference implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #18455
This commit implements
checkPrimeSyncandcheckPrimein node:crypto using the Miller-Rabin primality test (fun fact: it actually is a test for composite numbers)It first compares the candidate against many known small primes and if not, proceeds to run the Miller-Rabin primality test. http:https://nickle.org/examples/miller-rabin.5c used as reference implementation.