refactor(cli): remove Lazy<String> and fix help outputs #18462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Mar 27, 2023
Comment on lines
+698
to
+707
| crate::version::deno(), | ||
| if crate::version::is_canary() { | ||
| "canary" | ||
| } else { | ||
| env!("PROFILE") | ||
| }, | ||
| env!("TARGET"), | ||
| deno_core::v8_version(), | ||
| crate::version::TYPESCRIPT | ||
| ); |
There was a problem hiding this comment.
Ideally this would be a static string too, but that would require to change deno_core::v8_version() to acquire V8 version information during build time. Doable, but I don't have time for this now.
dsherret
reviewed
Mar 27, 2023
| @@ -957,19 +945,19 @@ fn compile_subcommand() -> Command { | |||
| deno compile -A https://deno.land/std/http/file_server.ts | |||
| deno compile --output color_util https://deno.land/std/examples/colors.ts | |||
|
|
|||
| Any flags passed which affect runtime behavior, such as '--unstable', \ | |||
There was a problem hiding this comment.
No more automatic wrapping for this?
There was a problem hiding this comment.
It appears this broke in clap v4 and we missed it when landing the PR
dsherret
approved these changes
Mar 27, 2023
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
This `Lazy<String>` calls were showing up on flamegraph and there's really no point in using them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
Lazy<String>calls were showing up on flamegraph and there'sreally no point in using them.