Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test for Linux shared libraries #18461

Merged
merged 2 commits into from
Mar 28, 2023
Merged

chore: add test for Linux shared libraries #18461

merged 2 commits into from
Mar 28, 2023

Conversation

andrewnester
Copy link
Contributor

Closes #18266

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@andrewnester andrewnester force-pushed the issue-18266 branch 2 times, most recently from b831878 to c222582 Compare March 27, 2023 16:05
@andrewnester
Copy link
Contributor Author

@bartlomieju seems like the test failure is not related (most probably just flaky) to the changes I made and newly added tests is passing. What is the current way of rerunning CI on pull requests?

Thank you!

@bartlomieju
Copy link
Member

@andrewnester you can either merge new version of main branch to your PR, or push an empty commit (git commit -m "reset CI" --allow-empty). Alternatively you can ping one of the maintainers to restart the CI.

littledivy
littledivy approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@littledivy littledivy enabled auto-merge (squash) March 28, 2023 08:41
@littledivy littledivy merged commit d0a0ff6 into denoland:main Mar 28, 2023
@andrewnester andrewnester deleted the issue-18266 branch March 28, 2023 09:02
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@andrewnester @mmastrac
chore: add test for Linux shared libraries (#18461)
22f5c25 
Closes #18266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add test for linux shared libraries
4 participants
@andrewnester @CLAassistant @bartlomieju @littledivy