fix(coverage): ignore files from npm registry

[GJZwiers]

Fixes #17664 and part of #18454 by excluding files belonging to npm modules by default in the coverage output.

[loynoir]

@GJZwiers

https://deno.com/blog/v1.29#custom-registry-support-via-environment-variable

registry.npmjs.org seems hardcoded.

https://github.com/denoland/deno/search?q=NPM_CONFIG_REGISTRY

I guess something like

e.url.startsWith(
  url.pathToFileURL(
    path.join(deno_cache_dir(), 'npm', partial_parsed_NPM_CONFIG_REGISTRY()) + path.sep
  )
)

[loynoir]

@GJZwiers

I still think should do some quoting.

I guess .base_url().domain() is something like js parsedURL.host or parsedURL.hostname.

Not my case, but what about below cases?

> NPM_CONFIG_REGISTRY=https://mirror deno ...

> NPM_CONFIG_REGISTRY=https://mirror:1234/sub/path deno ...

> NPM_CONFIG_REGISTRY=https://mirror:1234/sub/path/ deno ...

If user code path includes mirror, current PR implement will be too wide.

That's why I think need to be more specific, because npm registry is mutable, or said not-hardcoded.

e.url.startsWith(
  url.pathToFileURL(
    path.join(deno_cache_dir(), 'npm', partial_parsed_NPM_CONFIG_REGISTRY()) + path.sep
  )
)

[GJZwiers]

Thanks for the good points @loynoir! I have updated the npm folder path to be more specific.

[dsherret]

See comment. There is an easier way we can do this.

[dsherret]

Instead of all the above, the directory of where the npm files are found can be found on ps.npm_resolver.fs_resolver.root_dir_url(). We need to expose it on npm_resolver as something like ps.npm_resolver.root_dir_url(). Then we can provide the url to this function.

[GJZwiers]

Thank you @dsherret, that is a lot cleaner and fixes a failing test I was getting.

[dsherret]

LGTM! Thanks for this!