refactor(runtime): manual serialization of bootstrap data #18448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
commented
Mar 26, 2023
aapoalas
reviewed
Mar 27, 2023
aapoalas
reviewed
Mar 27, 2023
aapoalas
reviewed
Mar 27, 2023
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
This commit changes how data required to bootstrap main and worker runtime is serialized. Instead of relying on serde_v8 and using JSON object, we're doing manual serialization to a "v8::Array". This limits number of V8 strings that need to be serialized by 16. It also made it clear that some data could be obtained during snapshotting instead of during bootstrap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes how data required to bootstrap main and worker runtime
is serialized. Instead of relying on serde_v8 and using JSON object, we're doing
manual serialization to a "v8::Array". This limits number of V8 strings that need
to be serialized by 16. It also made it clear that some data could be obtained during
snapshotting instead of during bootstrap.