feat(bench): add --no-run flag
#18433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a flag to `deno bench` to type-check specifiers only similar to `deno test --no-run`
aapoalas
requested changes
Mar 26, 2023
| @@ -0,0 +1 @@ | |||
| const _value: string = 1; | |||
There was a problem hiding this comment.
Maybe add a console.log to the file to confirm that the code is not run at all, and not just that the benchmark calls themselves are not run.
aapoalas
approved these changes
Mar 26, 2023
|
Is it a breaking change in clap v4? |
Co-authored-by: Leo Kettmeir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to
deno benchto cache and type-check specifiers only, similar todeno test --no-runCloses #18429