chore: fix located_script_name test #18418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 24, 2023
| defaults: { | ||
| run: { | ||
| // GH actions doesn't use `set -e` by default unless you specify bash | ||
| shell: "bash", |
There was a problem hiding this comment.
It seems like a terrible decision/oversight that they didn't make this the default https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
mmastrac
approved these changes
Mar 24, 2023
|
Essentially GH actions does not have It looks like there are a lot of resources online and other github repos that are doing this wrong too. |
|
Someone followed up with me on the SO question and I realized this only occurs on Windows runners. |
mmastrac
pushed a commit
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18417