Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improving FS Error Message for op_realpath_sync and op_realpath_async #18404

Merged
merged 4 commits into from Mar 26, 2023
Merged

chore: Improving FS Error Message for op_realpath_sync and op_realpath_async #18404

merged 4 commits into from Mar 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2023

@ghost ghost marked this pull request as ready for review March 24, 2023 01:24
@ghost ghost changed the title Improving FS Error Message for op_realpath_sync and op_realpath_async chore: Improving FS Error Message for op_realpath_sync and op_realpath_async Mar 24, 2023
aapoalas
aapoalas requested changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good but a nitpick kind of issue regarding the formatted error messages should be resolved before merging to align with all the other FS error messages.

ext/fs/lib.rs Outdated Show resolved Hide resolved
ext/fs/lib.rs Outdated Show resolved Hide resolved
aapoalas
aapoalas approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the fix!

@aapoalas aapoalas merged commit 3c5350f into denoland:main Mar 26, 2023
@andrewnester andrewnester mentioned this pull request Mar 28, 2023
Closed
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@WingZer0o @mmastrac
chore: Improving FS Error Message for op_realpath_sync and op_realpat…
02401b2 
…h_async (#18404)

#17526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aapoalas @WingZer0o