Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document Node.js compat test setup script #18381

Merged
merged 5 commits into from
Mar 26, 2023
Merged

chore: document Node.js compat test setup script #18381

merged 5 commits into from
Mar 26, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 23, 2023

No description provided.

aapoalas
aapoalas approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a nitpick, I might document how the tests are run in a separate section instead of having it appear as part of "Steps to add new test cases".

aapoalas
aapoalas approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@aapoalas aapoalas merged commit 8b596cb into denoland:main Mar 26, 2023
@kt3k kt3k deleted the document-node-compat-tools branch March 26, 2023 11:36
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@kt3k @mmastrac
chore: document Node.js compat test setup script (#18381)
0389b7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kt3k @aapoalas