test(runtime): support Windows in resolve_from_cwd_absolute #18379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
current_dir().unwrap() joined with a Path is equivalent to the implementation in resolve_from_cwd(). Manually tested on Ubuntu 22.04 and Windows 11. Signed-off-by: Elijah Conners <[email protected]>
ElijahPepe
force-pushed
the
fix/resolve_from_cwd_absolute
branch
from
0d6a863
to
087670e
Compare
dsherret
changed the title
aapoalas
approved these changes
Mar 25, 2023
levex
pushed a commit
that referenced
this pull request
Apr 18, 2023
`current_dir().unwrap()` joined with a Path is equivalent to the implementation in `resolve_from_cwd()`. Manually tested on Ubuntu 22.04 and Windows 11. Signed-off-by: Elijah Conners <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current_dir().unwrap()joined with a Path is equivalent to the implementation inresolve_from_cwd(). Manually tested on Ubuntu 22.04 and Windows 11.