Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): measure performance against wall-clock #18357

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

mmastrac
Copy link
Contributor

Fixes test flake by requiring perf to be <150% of wall-clock time rather than <500ms.

@mmastrac mmastrac requested a review from dsherret March 22, 2023 16:51
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and good idea! This should stop it from being flaky.

For reference, the flaky test output is:

performanceMeasure => ./cli/tests/unit/performance_test.ts:79:6
error: AssertionError: duration exceeds 500ms: 550.7588259999998
    throw new AssertionError(msg);
          ^
    at assert (file:https:///Users/runner/work/deno/deno/test_util/std/testing/asserts.ts:141:11)
    at file:https:///Users/runner/work/deno/deno/cli/tests/unit/performance_test.ts:105:9

 FAILURES 

performanceMeasure => ./cli/tests/unit/performance_test.ts:79:6

@mmastrac mmastrac enabled auto-merge (squash) March 22, 2023 17:04
@mmastrac mmastrac merged commit 03e236b into denoland:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants