Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): add createDecipheriv #18245

Merged
merged 2 commits into from
Mar 18, 2023
Merged

fix(ext/node): add createDecipheriv #18245

merged 2 commits into from
Mar 18, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 17, 2023

Continued from #18091

This PR adds crypto.createDecipheriv with 'aes-128-cbc' algorithm support.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @littledivy please review and approve

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've some ideas to optimize certain paths - I'll try to put them in an issue / doc

@kt3k kt3k merged commit 5223f3d into denoland:main Mar 18, 2023
@kt3k kt3k deleted the node-decipheriv branch March 18, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants