Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix ci to restore the cache #18215

Merged
merged 3 commits into from
Mar 15, 2023
Merged

chore(ci): fix ci to restore the cache #18215

merged 3 commits into from
Mar 15, 2023

Conversation

dsherret
Copy link
Member

No description provided.

@dsherret dsherret enabled auto-merge (squash) March 15, 2023 21:28
@dsherret dsherret requested a review from mmastrac March 15, 2023 21:45
mmastrac
mmastrac approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret merged commit 1c285ac into denoland:main Mar 15, 2023
@dsherret dsherret deleted the chore_ci branch March 15, 2023 22:03
@dsherret
Copy link
Member Author

16 minute CI run compared to 30. That's much better.

It seems we can get it lower by also caching the "test debug ubuntu-22.04-xl" builds... for some reason they're not cached. I'll open a separate PR.

kt3k pushed a commit that referenced this pull request Mar 16, 2023
@dsherret @kt3k
chore(ci): fix ci to restore the cache (#18215)
994eb1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsherret @mmastrac