Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple code: omit comparison to bool constant #182

Closed
wants to merge 1 commit into from
Closed

simple code: omit comparison to bool constant #182

wants to merge 1 commit into from

Conversation

xuri
Copy link

@xuri xuri commented Jun 7, 2018

No description provided.

qti3e
qti3e reviewed Jun 7, 2018
View reviewed changes
Copy link
Contributor

@qti3e qti3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuri Thank you, but I've written util_test.go in this way for better readability:

patternMatch(...) != boolean

same as:

actual != expected

@xuri
Copy link
Author

xuri commented Jun 7, 2018

OK, I'll close this PR.

@xuri xuri closed this Jun 7, 2018
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@bartlomieju @ry
support NO_COLOR in colors module (denoland#182)
a81d2ae
humancalico pushed a commit to humancalico/deno that referenced this pull request Aug 24, 2020
@bartlomieju
Update README.md (denoland#182)
19e22d3
bartlomieju added a commit that referenced this pull request Mar 18, 2023
@bartlomieju
Revert "perf(core): use static specifier in ExtensionFileSource (#182… (
f6c364f 
#18270)

…64)"

This reverts commit 8af0c83.

Causes bench stage to fail on CI.
@jeremyroman jeremyroman mentioned this pull request Nov 21, 2023
Merged
5 tasks
hardfist pushed a commit to hardfist/deno that referenced this pull request Aug 7, 2024
@denobot @mmastrac
0.209.0 (denoland#182)
d90e42e 
Co-authored-by: mmastrac <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qti3e qti3e qti3e left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xuri @qti3e