Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update to Ubuntu-22.04-XL runners #18181

Merged
merged 15 commits into from
Mar 14, 2023
Merged

ci: update to Ubuntu-22.04-XL runners #18181

merged 15 commits into from
Mar 14, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Mar 14, 2023 •
edited by bartlomieju
Loading

Updates CI to use ubuntu-22.04-xl runners. A change to sysroot setup
was necessary that links libdl.so.2 and libdl.a that are no longer
present on ubuntu-22.04.

@littledivy littledivy marked this pull request as ready for review March 14, 2023 10:35
@littledivy littledivy added the ci-test-flaky put this on a PR to run concurrent workflows label Mar 14, 2023
@littledivy littledivy removed the ci-test-flaky put this on a PR to run concurrent workflows label Mar 14, 2023
bartlomieju
bartlomieju requested changes Mar 14, 2023
View reviewed changes
.github/workflows/ci.generate.ts Outdated Show resolved Hide resolved
.github/workflows/ci.generate.ts Outdated Show resolved Hide resolved
This was referenced Mar 14, 2023
Closed
Closed
Closed
Closed
@bartlomieju bartlomieju changed the title try ci ci: update to Ubuntu-22.04-XL runners Mar 14, 2023
@bartlomieju
Copy link
Member

@littledivy are libdl.so and libdl.a files are needed here?

@littledivy
Copy link
Member Author

@bartlomieju yeah those are needed, they are from ubuntu 20's libc6-dev. I'll add them to deno_third_party

@littledivy
Copy link
Member Author

It works.

[ec2-user@ip-172-31-53-34 ~]$ objdump -T ./deno | grep -E 'GLIBC_2.[23][0-9]'
[ec2-user@ip-172-31-53-34 ~]$ ./deno
Deno 1.31.2
exit using ctrl+d, ctrl+c, or close()
REPL is running with all permissions allowed.
To specify permissions, run `deno repl` with allow flags.
> 
[ec2-user@ip-172-31-53-34 ~]$

@littledivy littledivy added the ci-test-flaky put this on a PR to run concurrent workflows label Mar 14, 2023
@littledivy littledivy removed the ci-test-flaky put this on a PR to run concurrent workflows label Mar 14, 2023
bartlomieju
bartlomieju approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 485e120 into denoland:main Mar 14, 2023
@bartlomieju bartlomieju deleted the update_ubuntu22 branch March 14, 2023 16:45
kt3k pushed a commit that referenced this pull request Mar 16, 2023
@littledivy @bartlomieju @kt3k
ci: update to Ubuntu-22.04-XL runners (#18181)
a24f570 
Updates CI to use ubuntu-22.04-xl runners. A change to sysroot setup
was necessary that links `libdl.so.2` and `libdl.a` that are no longer
present on ubuntu-22.04.

---------

Co-authored-by: Bartek Iwańczuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@littledivy @bartlomieju