Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(runtime): fix build.rs (2) #18113

Merged
merged 1 commit into from
Mar 10, 2023
Merged

chore(runtime): fix build.rs (2) #18113

merged 1 commit into from
Mar 10, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 10, 2023

ref #18112
ref #18093

@kt3k kt3k requested a review from littledivy March 10, 2023 06:38
dsherret
dsherret approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member Author

kt3k commented Mar 10, 2023

I'm landing without waiting for CI as this is not targeted to main, and also is a part of release process

@kt3k kt3k merged commit fc6edac into v1.31 Mar 10, 2023
@kt3k kt3k deleted the fix-runtime-build-rs-2 branch March 10, 2023 06:41
denobot pushed a commit that referenced this pull request Mar 10, 2023
@kt3k
chore(runtime): fix build.rs (2) (#18113)
731c160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kt3k @dsherret @littledivy