Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename welcome.js to welcome.ts #1803

Merged
merged 3 commits into from
Feb 18, 2019

Conversation

Maxim-Mazurok
Copy link
Contributor

@Maxim-Mazurok Maxim-Mazurok commented Feb 17, 2019

Sorry, I've created it on accident, I wanted to discuss it on gitter prior to opening a PR. But since it's already opened, it doesn't make a lot of sense closing it.

The idea is to change welcome.js from the example on the website, to welcome.ts, to highlight that deno is capable of compiling TypeScript, not only execute JavaScript files.

@Maxim-Mazurok Maxim-Mazurok changed the title Maxim mazurok patch 1 Rename welcome.js to welcome.ts Feb 17, 2019
@Maxim-Mazurok
Copy link
Contributor Author

Probably, it's a good idea to leave both welcome.js and welcome.ts to be on the safe side, just in case if there are any other tutorials in the wild that are using welcome.js.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sure. lgtm

@ry ry merged commit 55b2f01 into denoland:master Feb 18, 2019
@Maxim-Mazurok
Copy link
Contributor Author

So, we're not keeping welcome.js, right? Just making sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants