Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime): merge "spawn" into "process" #18022

Merged
merged 3 commits into from
Mar 5, 2023

Conversation

bartlomieju
Copy link
Member

This commit merges "runtime/js/40_spawn.js" into "runtime/js/40_process.js",
and "runtime::ops::spawn" into "runtime::ops::process".

It makes little sense to have them separated given that we want to factor out these
APIs into a separate extension crate.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju enabled auto-merge (squash) March 5, 2023 12:14
@bartlomieju bartlomieju merged commit de0d148 into denoland:main Mar 5, 2023
@bartlomieju bartlomieju deleted the merge_process_and_spawn branch March 5, 2023 12:21
kt3k pushed a commit that referenced this pull request Mar 10, 2023
This commit merges "runtime/js/40_spawn.js" into
"runtime/js/40_process.js", and "runtime::ops::spawn" 
into "runtime::ops::process".

It makes little sense to have them separated given that we want to
factor out these APIs into a separate extension crate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants