Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused 40_diagnostics.js file #18021

Merged
merged 2 commits into from
Mar 5, 2023

Conversation

bartlomieju
Copy link
Member

This file was not used anywhere - even though it exposed an unstable
"Deno.DiagnosticCategory" API. Seems like a left over from when we
had "Deno.emit" API.

@bartlomieju bartlomieju enabled auto-merge (squash) March 5, 2023 02:25
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM

@bartlomieju bartlomieju merged commit 17574f1 into denoland:main Mar 5, 2023
@bartlomieju bartlomieju deleted the remove_diagnostic_category branch March 5, 2023 03:06
kt3k pushed a commit that referenced this pull request Mar 10, 2023
This file was not used anywhere - even though it exposed an unstable
"Deno.DiagnosticCategory" API. Seems like a left over from when we
had "Deno.emit" API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants