Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cargo build rebuilding deno_runtime each time #17978

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

dsherret
Copy link
Member

No description provided.

@@ -146,7 +146,6 @@ pub fn init_polyfill() -> Extension {
"_pako.mjs",
"_process/exiting.ts",
"_process/process.ts",
"_process/stdio.mjs",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this was asserted to exist somehow

Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dsherret dsherret enabled auto-merge (squash) February 28, 2023 19:06
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

This was missed in #17911

@dsherret dsherret merged commit 6ffbf8a into denoland:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants