Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ext/ffi): Use queueMicrotask in tests #17954

Merged

Conversation

aapoalas
Copy link
Collaborator

Absolutely nothingburger of a PR: I just hadn't realized queueMicrotask() is a thing and wrote tests using Promise.resolve().then() in its stead.

Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lugutomi!

@aapoalas aapoalas merged commit e047225 into denoland:main Feb 26, 2023
@aapoalas aapoalas deleted the chore/ffi-thread-safe-use-queue-microtask branch February 26, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants