Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(flash): move remoteAddr to options bag #17913

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

crowlKats
Copy link
Member

Applies suggestion from #17912

ext/flash/01_http.js Outdated Show resolved Hide resolved
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @bartlomieju ptal also

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@crowlKats crowlKats merged commit 484b6fe into denoland:main Feb 24, 2023
@crowlKats crowlKats deleted the serve_proper_remote_addr branch February 24, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants