chore(ext/node): suppress node compat tests stdout by default #17909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
Feb 24, 2023
cli/tests/node_compat/test.ts
Outdated
| @@ -78,7 +79,7 @@ for await (const path of testPaths) { | |||
| }); | |||
| const { code, stdout, stderr } = await command.output(); | |||
|
|
|||
| if (stdout.length) console.log(decoder.decode(stdout)); | |||
| if (stdout.length && hasFilters) console.log(decoder.decode(stdout)); | |||
There was a problem hiding this comment.
Can you make it display the output if code is non-zero?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses the stdout of Node.js compat test cases when they are executed without any filter. (The console output of node.js compat testing is large and they are not useful when running the entire test cases.)
The stdout is still displayed when the developer specifies any test case filter.