Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): fix node stream #17874

Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix(ext/node): fix node stream #17874

merged 2 commits into from
Feb 22, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 22, 2023

This PR fixes the reference errors of Blob and AbortController in _stream.mjs. (The diff doesn't work because of minified source code, but this PR replaces globalThis.AbortController to imported AbortController and globalThis.Blob to imported Blob. (These are not available via globalThis at snapshot time).

(Fixes #17859, especially Migration engine exited error seems fixed with this change)

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

@kt3k kt3k merged commit a2d942a into denoland:main Feb 22, 2023
@kt3k kt3k deleted the fix-node-stream branch February 22, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm:prisma db push throws Migration engine exited
2 participants