Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/napi): correct name handling in napi property descriptor #17716

Merged
merged 2 commits into from
Feb 10, 2023
Merged

fix(cli/napi): correct name handling in napi property descriptor #17716

merged 2 commits into from
Feb 10, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Feb 10, 2023 •
edited
Loading

Fixes #17712

@littledivy littledivy changed the title fix(napi): handle name correct in napi property descriptor fix(cli/napi): correct name handling in napi property descriptor Feb 10, 2023
ry
ry approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 39f131c into denoland:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

name property not handled in napi_define_properties
2 participants
@littledivy @ry