Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate Deno.run API in favor of Deno.Command #17630

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

bartlomieju
Copy link
Member

Blocked on #17628

@bartlomieju bartlomieju changed the title [WIP] feat: Deprecate Deno.run API in favor of Deno.Command feat: Deprecate Deno.run API in favor of Deno.Command Feb 15, 2023
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 848e2c0 into denoland:main Feb 16, 2023
@bartlomieju bartlomieju deleted the deprecate_deno_run branch February 16, 2023 11:11
ry added a commit that referenced this pull request Feb 22, 2023
ry added a commit that referenced this pull request Feb 22, 2023
…" (#17875)

Deno.Command needs to be stabilized first and allow people to upgrade to
it before we can deprecate Deno.run. Otherwise lint will suddenly fail
with deprecated errors without giving people a chance to update.
bartlomieju added a commit to bartlomieju/deno that referenced this pull request Apr 26, 2023
bartlomieju added a commit that referenced this pull request Apr 27, 2023
This commit adds `@deprecated` comments to `Deno.run` API declarations.
Since stabilization of `Deno.Command` API in [Deno
v1.31](https://deno.com/blog/v1.31#api-stabilizations), `Deno.Command`
is the preferred (more reliable) API to interact with subprocesses.
This is the preparation for the removal of `Deno.run` API in Deno 2.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants