Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to Rust 1.67 #17548

Merged
merged 9 commits into from
Jan 27, 2023
Merged

chore: upgrade to Rust 1.67 #17548

merged 9 commits into from
Jan 27, 2023

Conversation

dsherret
Copy link
Member

No description provided.

dsherret
dsherret commented Jan 26, 2023
View reviewed changes
cli/napi/async.rs Outdated Show resolved Hide resolved
@dsherret dsherret marked this pull request as ready for review January 26, 2023 20:04
ry
ry reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@ry ry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is not bumping a version anywhere? I think we should be explicit about what version we're building against.

nevermind - I see it now

bartlomieju
bartlomieju approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit f5840bd into denoland:main Jan 27, 2023
@dsherret dsherret deleted the chore_upgrade_rust_1_67 branch January 27, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dsherret @ry @bartlomieju