Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi): handle return value from initializer #17502

Merged
merged 3 commits into from
Jan 23, 2023
Merged

fix(napi): handle return value from initializer #17502

merged 3 commits into from
Jan 23, 2023

Conversation

littledivy
Copy link
Member

Fixes #17349

bartlomieju
bartlomieju approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for fixing this

@littledivy littledivy merged commit c3e0b12 into denoland:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

napi: returning value from initializer is ignored
2 participants
@littledivy @bartlomieju