Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repl): improve validator to mark more code as incomplete #17443

Merged
merged 1 commit into from
Jan 16, 2023
Merged

fix(repl): improve validator to mark more code as incomplete #17443

merged 1 commit into from
Jan 16, 2023

Conversation

dsherret
Copy link
Member

Closes #17442

bartlomieju
bartlomieju approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 9d3483d into denoland:main Jan 16, 2023
@dsherret dsherret deleted the fix_improve_repl_validator branch January 16, 2023 14:50
bartlomieju pushed a commit that referenced this pull request Jan 16, 2023
@dsherret @bartlomieju
fix(repl): improve validator to mark more code as incomplete (#17443)
c036c12 
Closes #17442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected parse error inside deno REPL
2 participants
@dsherret @bartlomieju