fix(npm): handle an npm package that has itself as a dependency #17425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 14, 2023
| @@ -303,6 +303,7 @@ impl Graph { | |||
| parent_id: &NpmPackageId, | |||
| ) { | |||
| let mut child = (*child).lock(); | |||
| assert_ne!(child.id, *parent_id); | |||
There was a problem hiding this comment.
Need to do this before it would deadlock on the line below.
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2023
I'm not sure this properly handles scenarios where an npm package uses an alias that resolves to itself, we can fix that if we find a package that actually depends on that behavior. Closes #17420
MierenManz
added a commit
to MierenManz/oned
that referenced
this pull request
Jan 20, 2023
…cy (denoland#17425)" This reverts commit 7cd249d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this properly handles scenarios where an npm package uses an alias that resolves to itself, we can fix that if we find a package that actually depends on that behavior.
Closes #17420