refactor(tsc): do not store some typescript declaration file text in multiple places #17410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
dsherret
changed the title
bartlomieju
approved these changes
Jan 14, 2023
| @@ -385,7 +385,7 @@ delete Object.prototype.__proto__; | |||
| // paths must be either relative or absolute. Since | |||
| // analysis in Rust operates on fully resolved URLs, | |||
| // it makes sense to use the same scheme here. | |||
| const ASSETS = "asset:https:///"; | |||
| const ASSETS_URL_PREFIX = "asset:https:///"; | |||
There was a problem hiding this comment.
We were supposed to change it to deno:https:///assets/, didn't we?
There was a problem hiding this comment.
Not yet and I’m not sure yet. Need to investigate more
Comment on lines
+110
to
+119
| let mut runtime = JsRuntime::new(RuntimeOptions { | ||
| startup_snapshot: Some(compiler_snapshot()), | ||
| extensions: vec![Extension::builder("deno_cli_tsc") | ||
| .ops(get_tsc_ops()) | ||
| .build()], | ||
| ..Default::default() | ||
| }); | ||
| let global = | ||
| runtime.execute_script("get_assets.js", "globalThis.getAssets()")?; | ||
| let scope = &mut runtime.handle_scope(); |
There was a problem hiding this comment.
Hopefully deno types is not used by a hot path by any user code, this will incur about 20ms startup cost
There was a problem hiding this comment.
That sounds fine. People could cache it if they care about 20ms.
bartlomieju
pushed a commit
that referenced
this pull request
Jan 16, 2023
…multiple places (#17410)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stores some declaration files only in the tsc snapshot instead of in the snapshot and in the binary. Due to this,
deno typesnow needs to get its information from a JS runtime.Before: 69,987 KB (binary size on Windows)
After:
68,195 KB69,324 KB (in this PR I previously moved everything to the snapshot and it had a greater reduction in size probably because the snapshot is compressed, but that led to an increase in memory usage of 0.5MB)