-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rationalise compiler ops #1740
Rationalise compiler ops #1740
Conversation
26b0a04
to
d586dfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly worried we may want CodeCache in the compiler isolate again at some point in the future - but I think it's good practice to remove dead code.
waiting for signature change on compile_sync
d586dfe
to
ec69206
Compare
Ok, the PR now does the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks Kitson !
This PR removes the code cache OP from the runtime and rationalises the response from the compiler. Currently, the compiler performs a cache op and then returns the full module (including the source code) back to Rust. Rust already knows the source code and knows it needs to try to cache the result after a compile, so it handles all of this, removing the need for the compiler to perform these actions.
Because I am still a Rust infant, I am sure I made mistakes in the Rust code.
I still need to restore the tests and write new ones.I made the decision to rename
CodeFetchOutput
toModuleMetaData
because that seem better to represent what is happening, as the object doesn't always come from a code fetch and is incrementally enhanced after the compile.