Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Response): use byte stream for string or uint8array #17387

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

crowlKats
Copy link
Member

For #17386

@bartlomieju
Copy link
Member

@crowlKats could you look into enabling relevant WPT tests for this change?

@crowlKats
Copy link
Member Author

@bartlomieju as per the linked issue, there currently arent any, this is a deno-specific problem; wpt tests around this will be available once the spec change is completed

@crowlKats
Copy link
Member Author

though seems wpts are failing for some reason. will investigate

@Macil
Copy link

Macil commented Jan 30, 2023

It's not enough to add type: "bytes" to get a usable byte stream. The controller.byobRequest value must be checked and used correctly in streams that set the type to bytes. This PR would cause the same issue that exists in Blob streams currently: #14219 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants